On Thu, Dec 01, 2016 at 11:36:24AM +0530, Souptick Joarder wrote:
> On Mon, Nov 28, 2016 at 6:21 PM, Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
> > In mthca_create_ah(), pci_pool_alloc() followed by memset will be
> > replaced by pci_pool_zalloc()
> >
> > Signed-off-by: Souptick joarder <jrdr.linux@xxxxxxxxx>
> > ---
> > drivers/infiniband/hw/mthca/mthca_av.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/mthca/mthca_av.c b/drivers/infiniband/hw/mthca/mthca_av.c
> > index bcac294..c202c89 100644
> > --- a/drivers/infiniband/hw/mthca/mthca_av.c
> > +++ b/drivers/infiniband/hw/mthca/mthca_av.c
> > @@ -186,7 +186,7 @@ int mthca_create_ah(struct mthca_dev *dev,
> >
> > on_hca_fail:
> > if (ah->type == MTHCA_AH_PCI_POOL) {
> > - ah->av = pci_pool_alloc(dev->av_table.pool,
> > + ah->av = pci_pool_zalloc(dev->av_table.pool,
> > GFP_ATOMIC, &ah->avdma);
> > if (!ah->av)
> > return -ENOMEM;
> > @@ -196,7 +196,6 @@ int mthca_create_ah(struct mthca_dev *dev,
> >
> > ah->key = pd->ntmr.ibmr.lkey;
> >
> > - memset(av, 0, MTHCA_AV_SIZE);
> >
> > av->port_pd = cpu_to_be32(pd->pd_num | (ah_attr->port_num << 24));
> > av->g_slid = ah_attr->src_path_bits;
> > --
> > 1.9.1
> >
>
> Any comment on this patch?
I believe the same comments as for "mellanox :mlx4: Replace pci_pool_alloc
by pci_pool_zalloc", i.e. indentation of GFP_ATOMIC (AFAIK it can join the
line above) and removal of unneeded empty line.
Besides these two cosmetics comments the patch seems to be fine.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
