On Tue, Nov 29, 2016 at 05:06:55PM +0200, Roi Dayan wrote: > I really didn't see this. sparse and smatch didn't catch this. I use > FC24 and gcc 6.2.1 for compilation and it doesn't give me any > warning. > Did another check with an old rhel machine with gcc 4.4.6 and I got > a warning about it there. > Can you tell me which tool you used? Some new unreleased Smatch stuff I'm working on. > > This is a false positive because of the first check if vport > 1, we > actually check prev_mlx5_mode from the second for-loop > iteration and on the first loop iteration we set a value (in line 952). > It is used to check if all vports are set with the same inline mode. Oh crap... Smatch takes a short cut handling loops (I really need to fix this but I wrote the orginal code a decade ago). I misread how the loops works as well. Sorry for the noise. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html