Hi Yuval, > v3: > - Fixed alignment issues You mean remove extra empty line? Yes, I removed the empty line and also I had fixed one alignment issue which was mentioned by Sergei in v2 patch. On Wed, Nov 30, 2016 at 1:28 AM, Yuval Shaia <yuval.shaia@xxxxxxxxxx> wrote: > On Wed, Nov 30, 2016 at 01:16:12AM +0530, Souptick Joarder wrote: >> In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset will be >> replaced by pci_pool_zalloc() >> >> Signed-off-by: Souptick joarder <jrdr.linux@xxxxxxxxx> >> --- >> v3: >> - Fixed alignment issues > > You mean remove extra empty line? > > Reviewed-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx> > >> >> v2: >> - Address comment from sergei >> Alignment was not proper >> >> drivers/net/ethernet/mellanox/mlx4/cmd.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c b/drivers/net/ethernet/mellanox/mlx4/cmd.c >> index e36bebc..a49072b4 100644 >> --- a/drivers/net/ethernet/mellanox/mlx4/cmd.c >> +++ b/drivers/net/ethernet/mellanox/mlx4/cmd.c >> @@ -2679,15 +2679,13 @@ struct mlx4_cmd_mailbox *mlx4_alloc_cmd_mailbox(struct mlx4_dev *dev) >> if (!mailbox) >> return ERR_PTR(-ENOMEM); >> >> - mailbox->buf = pci_pool_alloc(mlx4_priv(dev)->cmd.pool, GFP_KERNEL, >> - &mailbox->dma); >> + mailbox->buf = pci_pool_zalloc(mlx4_priv(dev)->cmd.pool, GFP_KERNEL, >> + &mailbox->dma); >> if (!mailbox->buf) { >> kfree(mailbox); >> return ERR_PTR(-ENOMEM); >> } >> >> - memset(mailbox->buf, 0, MLX4_MAILBOX_SIZE); >> - >> return mailbox; >> } >> EXPORT_SYMBOL_GPL(mlx4_alloc_cmd_mailbox); >> -- >> 1.9.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html