Besides the soft-aggressive commit message -:) Reviewed-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx> On Thu, Nov 17, 2016 at 02:00:05PM +0300, Dan Carpenter wrote: > It makes me nervous when we cast pointer parameters. I would estimate > that around 50% of the time, it indicates a bug. Here the cast is not > needed becaue u32 and and unsigned int are the same thing. Removing the > cast makes the code more robust and future proof in case any of the > types change. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/drivers/infiniband/sw/rxe/rxe_srq.c b/drivers/infiniband/sw/rxe/rxe_srq.c > index 2a6e3cd..efc832a 100644 > --- a/drivers/infiniband/sw/rxe/rxe_srq.c > +++ b/drivers/infiniband/sw/rxe/rxe_srq.c > @@ -169,7 +169,7 @@ int rxe_srq_from_attr(struct rxe_dev *rxe, struct rxe_srq *srq, > } > } > > - err = rxe_queue_resize(q, (unsigned int *)&attr->max_wr, > + err = rxe_queue_resize(q, &attr->max_wr, > rcv_wqe_size(srq->rq.max_sge), > srq->rq.queue->ip ? > srq->rq.queue->ip->context : > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
