On Thu, Nov 10, 2016 at 6:47 PM +0200, Jason Gunthorpe wrote: >On Thu, Nov 10, 2016 at 09:22:42AM +0200, Leon Romanovsky wrote: >> I'll let to Bodong to elaborate on it more, but as far as I see, the >> AH attribute is relevant to UD QP only, while the packet pacing is >> intended for all types of QPs. >In IB static rate is supposed to work for all QP types. Indeed we already have a static_rate field, which applies to all IB traffic (including UD). The problem is: - This field is only u8, and uses IB standard rate enumerations. For pacing, we need arbitrary rates. - The field doesn't apply to Raw Ethernet QPs, AH or AV which isn't applicable to Raw Ethernet. It is incorrect to support AV/AH for Raw Ethernet QPs. The rate_limit configuration came form the application like required BW for the streaming and not from the fabric (SM). The rate_limit resolution is much higher and it is 1Kb/s. Both of the fields are limit the rate but coming from a different entities and required separate fields. The actual limit should be the minimum of both of them. Rony >Jason ��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f