On Tue, Nov 08, 2016 at 05:23:35PM -0800, Christoph Hellwig wrote: > On Sat, Nov 05, 2016 at 09:01:36AM -0600, Jason Gunthorpe wrote: > > > Not entirely. You want me to keep the ABI file from the kernel in the > > > fix up folder and also keep a file with the modified structs in > > > providers/pvrdma? > > > > Yes, and the file with the modified structs should include the kernel > > header and duplicate it minimally. This will make it simpler for us to > > eventually get rid of it. > > Can we just automate generating the user header, e.g. have a sed script > that recognized a magic comments ala > > /* LIBIBVERBS PREAMBLE (DO NOT REMOVE) */ > > and just insers the needed fields? Yah, something like that is a maybe, but if the drivers are going to be small like pvrdma, I think we are OK with this approach.. I haven't had time to audit what is needed beyond knowing that the uverbs header is actually quite big. Adit, make sure you push your patch to github too.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
