Two (extremely) minor suggestions inline.
Yuval
On Mon, Oct 31, 2016 at 12:21:35PM +0200, Leon Romanovsky wrote:
> From: Bodong Wang <bodong@xxxxxxxxxxxx>
>
> Add new member rate_limit to ib_qp_attr, it shows the packet pacing rate
Suggesting to replace with:
Add new member rate_limit to ib_qp_attr which holds the packet pacing rate
> in Kbps, 0 means unlimited.
>
> IB_QP_RATE_LIMIT is added to ib_attr_mask, and it could be used by RAW
Suggesting to replace with:
IB_QP_RATE_LIMIT is added to ib_attr_mask and could be used by RAW
> QPs when changing QP state from RTR to RTS, RTS to RTS.
>
> Signed-off-by: Bodong Wang <bodong@xxxxxxxxxxxx>
> Reviewed-by: Matan Barak <matanb@xxxxxxxxxxxx>
> Signed-off-by: Leon Romanovsky <leon@xxxxxxxxxx>
> ---
> drivers/infiniband/core/verbs.c | 2 ++
> include/rdma/ib_verbs.h | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
> index 8368764..3e688b3 100644
> --- a/drivers/infiniband/core/verbs.c
> +++ b/drivers/infiniband/core/verbs.c
> @@ -1014,6 +1014,7 @@ static const struct {
> IB_QP_QKEY),
> [IB_QPT_GSI] = (IB_QP_CUR_STATE |
> IB_QP_QKEY),
> + [IB_QPT_RAW_PACKET] = IB_QP_RATE_LIMIT,
> }
> }
> },
> @@ -1047,6 +1048,7 @@ static const struct {
> IB_QP_QKEY),
> [IB_QPT_GSI] = (IB_QP_CUR_STATE |
> IB_QP_QKEY),
> + [IB_QPT_RAW_PACKET] = IB_QP_RATE_LIMIT,
> }
> },
> [IB_QPS_SQD] = {
> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
> index 5ad43a4..a065361 100644
> --- a/include/rdma/ib_verbs.h
> +++ b/include/rdma/ib_verbs.h
> @@ -1102,6 +1102,7 @@ enum ib_qp_attr_mask {
> IB_QP_RESERVED2 = (1<<22),
> IB_QP_RESERVED3 = (1<<23),
> IB_QP_RESERVED4 = (1<<24),
> + IB_QP_RATE_LIMIT = (1<<25),
> };
>
> enum ib_qp_state {
> @@ -1151,6 +1152,7 @@ struct ib_qp_attr {
> u8 rnr_retry;
> u8 alt_port_num;
> u8 alt_timeout;
> + u32 rate_limit;
> };
>
> enum ib_wr_opcode {
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
