On Fri, Oct 28, 2016 at 10:53:13PM +0000, Hefty, Sean wrote: > > The current code creates an IDR per type. Since types are currently > > common for all vendors and known in advance, this was good enough. > > However, the proposed ioctl based infrastructure allows each vendor > > to declare only some of the common types and declare its own specific > > types. > > > > Thus, we decided to implement IDR to be per device and refactor it to > > use a new file. > > I think this needs to be more abstract. I would consider introducing the concept of an 'ioctl provider', with the idr per ioctl provider. You could then make each ib_device an ioctl provider. (Just embed the structure). I believe this will be necessary to support the rdma_cm, ib_cm, as well as devices that export different sets of ioctls, where an ib_device isn't necessarily available. IDR management is internal to kernel and it looks like an easy one to extend in the future. > > Essentially, I would treat plugging into the uABI independent from plugging into the kernel verbs API. Otherwise, I think we'll end up with multiple ioctl 'frameworks'. > > - Sean > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html
Attachment:
signature.asc
Description: PGP signature
