On Monday, October 24, 2016 8:06:42 PM CEST Leon Romanovsky wrote: > > Acked-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> Thanks! > > drivers/infiniband/hw/mlx5/mr.c | 39 +++++++++++++++++++++------------------ > > 1 file changed, 21 insertions(+), 18 deletions(-) > > > > diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c > > index d4ad672b905b..88d8d292677b 100644 > > --- a/drivers/infiniband/hw/mlx5/mr.c > > +++ b/drivers/infiniband/hw/mlx5/mr.c > > @@ -815,29 +815,33 @@ static void prep_umr_unreg_wqe(struct mlx5_ib_dev *dev, > > umrwr->mkey = key; > > } > > > > -static struct ib_umem *mr_umem_get(struct ib_pd *pd, u64 start, u64 length, > > - int access_flags, int *npages, > > - int *page_shift, int *ncont, int *order) > > +static int mr_umem_get(struct ib_pd *pd, u64 start, u64 length, > > + int access_flags, struct ib_umem ** umem, > > I wonder if checkpatch does differentiate between "struct ib_umem ** umem" > and "struct ib_umem **umem". According to coding style, the second is preferable. It was unintended, I'll send a v2 patch in a minute. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html