On Thu, Oct 20, 2016 at 12:49:10PM +0300, Ram Amrani wrote:
> +struct {
> + unsigned int vendor;
> + unsigned int device;
> +} hca_table[] = {
needs static const, please check all your stuff for static and const..
> +int qelr_modify_qp(struct ibv_qp *, struct ibv_qp_attr *,
> + int ibv_qp_attr_mask);
> +int qelr_query_qp(struct ibv_qp *qp, struct ibv_qp_attr *attr, int attr_mask,
> + struct ibv_qp_init_attr *init_attr);
It would be nice to be consistent, I prefer the argument name to be in
the prototype.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
