RE: [PATCH rdma-core 2/4] glue/redhat: add udev/systemd/etc infrastructure bits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ok,

I have the C code ported to rdma-core but how do I do this in cmake?

AS_IF([test x$rdmandd = xyes], [
    PKG_CHECK_MODULES([UDEV], [libudev])
    AC_CONFIG_FILES([doc/man/rdma-ndd.8 \
                        etc/rdma-ndd.init \
                        etc/rdma-ndd.service])
    AC_SUBST([UDEV_CFLAGS])
    AC_SUBST([UDEV_LIBS])
    if test "$with_udev" = "yes"; then
        PKG_CHECK_EXISTS(libudev >= 218, [with_dev_logging=no],
                        [with_udev_logging=yes])
        if test "$with_udev_logging" = "yes"; then
                AC_DEFINE_UNQUOTED([HAVE_UDEV_LOGGING], 1,
                                [whether libudev logging can be used])
        fi
    fi
])

I've found a "modules" file which looks like it has a compatible BSD license and could be added but is there a better way?

http://fossies.org/linux/flightgear/CMakeModules/FindUDev.cmake

I also have to convert the man page from *.rst to man in some way...  Would it be ok if I put a dependency on rst2man in the repo?

Ira


> -----Original Message-----
> From: Jarod Wilson [mailto:jarod@xxxxxxxxxx]
> Sent: Tuesday, October 18, 2016 7:51 AM
> To: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx>
> Cc: Weiny, Ira <ira.weiny@xxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx; Doug
> Ledford <dledford@xxxxxxxxxx>; Hefty, Sean <sean.hefty@xxxxxxxxx>
> Subject: Re: [PATCH rdma-core 2/4] glue/redhat: add udev/systemd/etc
> infrastructure bits
> 
> On Mon, Oct 17, 2016 at 02:13:09PM -0600, Jason Gunthorpe wrote:
> > On Mon, Oct 17, 2016 at 07:10:46PM +0000, Weiny, Ira wrote:
> >
> > > What I have been worried about is conflicts between infiniband-diags
> > > and the new rdma-core.  RH made a separate package out of rdma-ndd
> > > so that would be easy but I don't think other distros have.
> >
> > > So how do you obsolete "part" of a package?
> >
> > The distros know how to do this, they just conflict with the old
> > version of infiniband-diags.
> 
> Yeah, basically, you spin up a new infiniband-diags package that doesn't have
> rdma-ndd and a new rdma-core package that includes it, along with (in
> rpm-ese) 'Conflicts: infiniband-diags < <first version w/o rdma-ndd>', and that
> should pretty much cover it.
> 
> --
> Jarod Wilson
> jarod@xxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux