From: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx> Date: Mon, 17 Oct 2016 05:21:21 -0700 > You should write this more succinctly as: > > static bool __netdev_has_upper_dev(struct net_device *upper_dev, void *data) > { > struct net_device *dev = data; > > return upper_dev == dev; > } > > bool netdev_has_upper_dev_all_rcu(struct net_device *dev, > struct net_device *upper_dev) > { > return netdev_walk_all_upper_dev_rcu(dev, > __netdev_has_upper_dev, upper_dev); > } > > No if/else needed. No cast of void * ptr need. Use const if possible? Agreed. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html