On Mon, Oct 10, 2016 at 06:34:43AM +0000, Amrani, Ram wrote: > > > +/* * CQE requester status enumeration */ enum > > > +rdma_cqe_requester_status_enum { > > > + RDMA_CQE_REQ_STS_OK, > > > + RDMA_CQE_REQ_STS_BAD_RESPONSE_ERR, > > > + RDMA_CQE_REQ_STS_LOCAL_LENGTH_ERR, > > > + RDMA_CQE_REQ_STS_LOCAL_QP_OPERATION_ERR, > > > + RDMA_CQE_REQ_STS_LOCAL_PROTECTION_ERR, > > > + RDMA_CQE_REQ_STS_MEMORY_MGT_OPERATION_ERR, > > > + RDMA_CQE_REQ_STS_REMOTE_INVALID_REQUEST_ERR, > > > + RDMA_CQE_REQ_STS_REMOTE_ACCESS_ERR, > > > + RDMA_CQE_REQ_STS_REMOTE_OPERATION_ERR, > > > + RDMA_CQE_REQ_STS_RNR_NAK_RETRY_CNT_ERR, > > > + RDMA_CQE_REQ_STS_TRANSPORT_RETRY_CNT_ERR, > > > + RDMA_CQE_REQ_STS_WORK_REQUEST_FLUSHED_ERR, > > > + MAX_RDMA_CQE_REQUESTER_STATUS_ENUM > > > > Please add "," at the last line of enums, it will allow future changes to these > > enums with minimal churn. > > This is a good idea and I've applied it to several enums in the patch. > However, I think that this specific enum should left be as is since the last element should always remain last as it is a MAX_* It makes sense, Thanks > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html
Attachment:
signature.asc
Description: PGP signature