On Sun, Oct 09, 2016 at 05:01:51PM -0600, Jason Gunthorpe wrote: > On Sun, Oct 09, 2016 at 08:46:01AM +0300, Leon Romanovsky wrote: > > > 1. Can we remove this uninitialized_var at all and simply replace by > > default values? > > I think people would complain about the extra stores. gcc 6 will > eliminate them, but older compilers will not. This unintialized_var(x) adds extra store too (... x = x ...). > > But yes, we could do this. > > > 2. Do we really want additional folder to ccan with such common headers? > > What about rename ccan to be util and put this new file there (in case > > you proceed with it)? > > I see the ccan directory as stuf from ccan that we are not going to > change, while util is for new stuff specific to this tree. And I see this folder as a location of shared code with different utils (ccan, custom, e.t.c), but it doesn't really matter now and I will be fine with any directory structure layout. Thanks > > Jason
Attachment:
signature.asc
Description: PGP signature
