Re: [PATCH] i40iw: Add Quality of Service support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 06, 2016 at 04:26:59PM -0500, Henry Orosco wrote:
> On Thu, Oct 06, 2016 at 07:00:16PM +0300, Leon Romanovsky wrote:
> > On Thu, Oct 06, 2016 at 10:21:28AM -0500, Henry Orosco wrote:
> > > Add support for QoS on QPs. Upon device initialization,
> > > a map is created from user priority to queue set
> > > handles. On QP creation, use ToS to look up the queue
> > > set handle for use with the QP.
> > >
> > > Signed-off-by: Faisal Latif <faisal.latif@xxxxxxxxx>
> > > Signed-off-by: Shiraz Saleem <shiraz.saleem@xxxxxxxxx>
> > > Signed-off-by: Henry Orosco <henry.orosco@xxxxxxxxx>
> > > ---
> > >  drivers/infiniband/hw/i40iw/i40iw.h       |   9 ++
> > >  drivers/infiniband/hw/i40iw/i40iw_cm.c    |  30 +++++-
> > >  drivers/infiniband/hw/i40iw/i40iw_cm.h    |   2 +-
> > >  drivers/infiniband/hw/i40iw/i40iw_ctrl.c  | 151 +++++++++++++++++++++++++++++-
> > >  drivers/infiniband/hw/i40iw/i40iw_d.h     |   2 +
> > >  drivers/infiniband/hw/i40iw/i40iw_hw.c    |  25 ++---
> > >  drivers/infiniband/hw/i40iw/i40iw_main.c  |  64 +++++++++++--
> > >  drivers/infiniband/hw/i40iw/i40iw_osdep.h |   2 +
> > >  drivers/infiniband/hw/i40iw/i40iw_p.h     |   2 +
> > >  drivers/infiniband/hw/i40iw/i40iw_puda.c  |   3 +-
> > >  drivers/infiniband/hw/i40iw/i40iw_type.h  |  18 +++-
> > >  drivers/infiniband/hw/i40iw/i40iw_utils.c |  45 +++++++++
> > >  drivers/infiniband/hw/i40iw/i40iw_verbs.c |   6 +-
> > >  13 files changed, 323 insertions(+), 36 deletions(-)
> >
> > I believe that it can be split to series.
>
> As all this code is a logical unit for QoS support, we thought
> it best to submit as a single patch.

Large logical unit --> patchset
~400 lines of code --> large unit

>
> Doug, what is your preference?
> >
> > >  mode change 100644 => 100755 drivers/infiniband/hw/i40iw/i40iw_cm.c
> > >  mode change 100644 => 100755 drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> >
> > Why did you change file's mode from 644 to 755?
>
> Nice catch! Will send out another version with this fixed.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux