>> + pd = kzalloc(sizeof(*pd), GFP_KERNEL); >> + if (!pd) { >> + DP_ERR(dev, "failed to alloce PD\n"); >> + return ERR_PTR(-ENOMEM); >> + } >> + >> + if (!dev->rdma_ctx) { >> + DP_ERR(dev, "invlaid RDMA context\n"); >> + return ERR_PTR(-EINVAL); > >Don't you want to free pd which was allocated a couple of lines before? Good catch. Thanks. >> + pbe = (struct regpair *)pbl_tbl->va; >> + if (!pbe) { >> + DP_ERR(dev, "pbe is NULL\n"); > > ???? Yep, I'll change this. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html