> Ugh, each patch keeps adding to this?
The logic in the patch series is to have each patch contain only what is necessary for the specific functionality it adds.
This made it harder on us to prepare but, IMHO, easier for the reviewer.
If you'd like to have this file in one chunk, I can do this. What do you prefer?
> > +struct qedr_create_qp_ureq {
> > + u32 qp_handle_hi;
> > + u32 qp_handle_lo;
> > +
> > + /* SQ */
> > + /* user space virtual address of SQ buffer */
> > + u64 sq_addr;
> > +
> > + /* length of SQ buffer */
> > + size_t sq_len;
>
> Do not use size_t, that is just asking for 32/64 bit interop problems.
OK
> > +struct qedr_create_qp_uresp {
> > + u32 qp_id;
> > + int atomic_supported;
>
> int again, etc. You get the idea.
Yeah, I did. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
