> > + > > + rc = ib_get_cached_gid(ibqp->device, attr->ah_attr.port_num, > > + attr->ah_attr.grh.sgid_index, &gid, &gid_attr); > > + if (!rc && !memcmp(&gid, &zgid, sizeof(gid))) > > + rc = -ENOENT; > > + > > + if (!rc && gid_attr.ndev) { <snip> > > + } > > + } > > + if (rc) > > + return -EINVAL; > > I think it is better to check "rc" right after call to ib_get_cached_gid(). Somehow this e-mail slipped. Thanks, will update. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html