On Mon, 2016-09-19 at 05:51 +0200, Knut Omang wrote:
> On Sun, 2016-09-18 at 21:01 -0600, Jason Gunthorpe wrote:
> > On Sat, Sep 17, 2016 at 05:59:11AM +0200, Knut Omang wrote:
> > > @@ -118,5 +118,9 @@ IBVERBS_1.1 {
> > > ibv_cmd_create_qp_ex2;
> > > ibv_cmd_open_qp;
> > > ibv_cmd_rereg_mr;
> > > +};
> > >
> > > +IBVERBS_1.3 {
> > > + global:
> > > + ibv_cmd_create_ah_ex;
> > > } IBVERBS_1.0;
> >
> > This will probably end up being 1.4, and the 'tree' structure is
> > wrong, do not move this line:
> >
> > > } IBVERBS_1.0;
>
> I was a bit concerned about the "structure", but ultimately decided to
> follow the pattern since I could not find any documentation with this syntax
> (which is probably because it is not supported?)
Without digging into the details of the ld map parser, my hunch is that
a version symbol optionally accepts the {}, and that the ; terminates it so
as far as ld is concerned, basically the final IBVERBS_1.0
just provides an empty list of additional symbols for IBVERBS_1.0
> As far as I can see, the final IBVERBS_1.0 does not have any effect at all,
> the symbol output seems identical, so it should probably be removed, but
> maybe as a separate patch, with explanation?
>
> Knut
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
