On Sun, Sep 11, 2016 at 10:15:42AM +0300, Leon Romanovsky wrote: > On Sat, Sep 10, 2016 at 10:47:19AM +0300, Leon Romanovsky wrote: > > On Fri, Sep 09, 2016 at 10:55:27AM +0800, David Chang wrote: > > > On Thu, Sep 08, 2016 at 05:07:52PM +0300, Leon Romanovsky wrote: > > > > On Wed, Sep 07, 2016 at 03:23:10PM +0800, David Chang wrote: > > > > > When using MAD_IFC command, we should also consider avoiding in > > > > > ISSI > 0 mode, otherwise most of the MAD_IFC command features > > > > > are deprecated and cannot be used. > > > > > > > > > > Fixes: d603c809ef91 ("IB/mlx5: Fix decision on using MAD_IFC") > > > > > Reported-by: Sujith Pandel <sujith_pandel@xxxxxxxx> > > > > > Signed-off-by: David Chang <dchang@xxxxxxxx> > > > > > > > > NAK, > > > > It is wrong, the deprecation is removed from programming manual. > > > > > > > > > > Without the patch, we got the following message. > > > [ 8.456327] mlx5_core 0000:03:00.0: firmware version: 12.12.780 > > > ... > > > > This command is supported only for physical function (PF) drivers > > and only when physical port is IB without relation to ISSI. > > > > When I'll return to office (next week), I'll check that we are checking > > this requirement correctly. > > > > Thanks for providing dump and FW version to reproduce it. > > Hi David, > > Please find this UNTESTED patch. We will do formal testing during the > coming work week and will properly submit it for inclusion for 4.8. > From 9147fabc9b189e09a982de8ac30f01f04468f6ce Mon Sep 17 00:00:00 2001 > From: Noa Osherovich <noaos@xxxxxxxxxxxx> > Date: Sun, 11 Sep 2016 10:00:27 +0300 > Subject: [PATCH rdma-rc] IB/mlx5: Enable MAD_IFC commands for IB ports only > Ok! Will test the patch later. Thanks, David Chang -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html