On Thu, Sep 01, 2016 at 09:54:17 -0700, Yuval Shaia wrote:
> On Wed, Aug 03, 2016 at 04:27:41PM -0700, Adit Ranadive wrote:
> +
> > + /* Activate pvrdma device */
> > + pvrdma_write_reg(dev, PVRDMA_REG_CTL,
> PVRDMA_DEVICE_CTL_ACTIVATE);
> > +
> > + /* Make sure the write is complete before reading status. */
> > + mb();
> > +
> > + /* Check if device was successfully activated */
> > + ret = pvrdma_read_reg(dev, PVRDMA_REG_ERR);
> > + if (ret != 0) {
> > + dev_err(&pdev->dev, "failed to activate device\n");
> > + ret = -EINVAL;
> > + goto err_disable_intr;
> > + }
>
> What if it will take the device to activate longer than the time between
> write to PVRDMA_DEVICE_CTL_ACTIVATE and read from
> PVRDMA_REG_ERR?
I don't think that would happen here since the device executes the command
pretty much synchronously.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
