> It is a mistake to not explicitly link to the libraries required. > Not linking causes the symbols to drop the symbol version which could > cause runtime problems down the road if pthreads ever goes through > another symbol version change. > > Signed-off-by: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> > --- > libcxgb3/configure.in | 2 ++ > libcxgb4/configure.in | 2 ++ > libhfi1verbs/configure.in | 2 ++ > libi40iw/configure.ac | 2 ++ > libipathverbs/configure.in | 2 ++ > libmlx4/configure.ac | 2 ++ > libmlx5/configure.ac | 3 +++ > libmthca/configure.in | 2 ++ > libnes/configure.in | 2 ++ > libocrdma/configure.in | 2 ++ > librxe/configure.in | 2 ++ > 11 files changed, 23 insertions(+) > > diff --git a/libcxgb3/configure.in b/libcxgb3/configure.in > index 9efc82d34f33..db9177230cae 100644 > --- a/libcxgb3/configure.in > +++ b/libcxgb3/configure.in > @@ -24,6 +24,8 @@ then > AC_CHECK_LIB(ibverbs, ibv_get_device_list, [], > AC_MSG_ERROR([ibv_get_device_list() not found. libcxgb3 requires > libibverbs.])) > fi > +AC_CHECK_LIB(pthread, pthread_mutex_init, [], > + AC_MSG_ERROR([pthread_mutex_init() not found. libibverbs requires > libpthread.])) > Nit: This should be "libcxgb3 requires..." Similar change needed for all of this patch. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
