On Wed, Sep 7, 2016 at 10:23 AM, David Chang <dchang@xxxxxxxx> wrote:
> When using MAD_IFC command, we should also consider avoiding in
> ISSI > 0 mode, otherwise most of the MAD_IFC command features
> are deprecated and cannot be used.
Ofcourse!!
Mark/Meny, didn't you stpped on it / addressed that as part of some
other counters work?
Doron, don't you see this as repeated 100% failure e.g with Eth SRIOV
VFs and/or RoCE devices?
Or.
>
> Fixes: d603c809ef91 ("IB/mlx5: Fix decision on using MAD_IFC")
> Reported-by: Sujith Pandel <sujith_pandel@xxxxxxxx>
> Signed-off-by: David Chang <dchang@xxxxxxxx>
> ---
> drivers/infiniband/hw/mlx5/main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
> index 1b4094baa2de..0796fb2b04f1 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -288,7 +288,8 @@ __be16 mlx5_get_roce_udp_sport(struct mlx5_ib_dev *dev, u8 port_num,
>
> static int mlx5_use_mad_ifc(struct mlx5_ib_dev *dev)
> {
> - return !MLX5_CAP_GEN(dev->mdev, ib_virt);
> + return !dev->mdev->issi &&
> + !MLX5_CAP_GEN(dev->mdev, ib_virt);
> }
>
> enum {
> --
> 2.6.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
