On Sun, Aug 21, 2016 at 04:24:53 -0700, Yuval Shaia wrote:
> One minor comment.
> Besides that:
> Reviewed-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>
>
> Yuval
>
> On Wed, Aug 03, 2016 at 04:27:30PM -0700, Adit Ranadive wrote:
> > We share some common structures with the user-level driver. This patch
> > adds those structures and shared functions to traverse the QP/CQ rings.
> >
> > Changes from v2->v3:
> > - Defined what -1 means for an index return value in pvrdma_uapi.h
> >
> > Reviewed-by: Jorgen Hansen <jhansen@xxxxxxxxxx>
> > Reviewed-by: George Zhang <georgezhang@xxxxxxxxxx>
> > Reviewed-by: Aditya Sarwade <asarwade@xxxxxxxxxx>
> > Reviewed-by: Bryan Tan <bryantan@xxxxxxxxxx>
> > Signed-off-by: Adit Ranadive <aditr@xxxxxxxxxx>
> > ---
> > drivers/infiniband/hw/pvrdma/pvrdma_uapi.h | 248 +++++++++++++++++++++++++++++
> > drivers/infiniband/hw/pvrdma/pvrdma_user.h | 99 ++++++++++++
> > 2 files changed, 347 insertions(+)
> > create mode 100644 drivers/infiniband/hw/pvrdma/pvrdma_uapi.h
> > create mode 100644 drivers/infiniband/hw/pvrdma/pvrdma_user.h
> >
...
> > +
> > +/* PVRDMA receive queue work request */
> > +struct pvrdma_rq_wqe_hdr {
> > + __u64 wr_id; /* wr id */
> > + __u32 num_sge; /* size of s/g array */
> > + __u32 total_len; /* reserved */
> > +};
> > +/* Use pvrdma_sge (ib_sge) for receieve queue s/g array elements. */
>
> This comment refers to a structure that defined in patch #2.
In v4, will move the pvrdma_sge struct here so its more consistent.
Thanks,
Adit
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
