Re: [PATCH rdma-next V3 6/6] RDMA/core: Unify style of IOCTL commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 04, 2016 at 02:30:35PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
>
> MAD and HFI1 have different naming convention, this patch
> simplifies and unifies their defines and names.
>
> As part of cleanup, the HFI1 _NUM() macro and command indexes
> were removed. It has a potential to break applications which use
> these defines directly, while shouldn't.
>
> Signed-off-by: Matan Barak <matanb@xxxxxxxxxxxx>
> Signed-off-by: Haggai Eran <haggaie@xxxxxxxxxxxx>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> Reviewed-by: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx>
> ---
>  include/uapi/rdma/rdma_user_ioctl.h | 98 ++++++++++++++-----------------------
>  1 file changed, 38 insertions(+), 60 deletions(-)
>

<....>

>  /*
> - * User IOCTLs can not go above 128 if they do then see common.h and change the
> - * base for the snoop ioctl
> + * General blocks assignments
> + * It is closed on purpose do not expose it it user space

Doug,
Do you mind to change "it it" to be "it to" and save to everyone
respin?

Thanks

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux