Re: [PATCH libibverbs 1/3] Add new call ibv_cmd_create_ah_ex which supports extra parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2016-09-04 at 20:38 -0600, Jason Gunthorpe wrote:
> On Sat, Sep 03, 2016 at 09:30:40AM +0200, Knut Omang wrote:
> 
> > Looking more closely at this whole problem, I think for my patch, 
> > the right solution is just to avoid adding a new function name and 
> > instead provide a redefinition of the original symbol with a new version 
> > using the __asm__(".symver ...) construct already nicely used for v.1.0 
> > bw compatibility - just following the pattern already established.
> 
> That is possible, but to date we have never done that and have
> continued to preserve source compatability for providers.
> 
> I agree the providers should be updated, but I don't see this being
> practical until after rdma-plumbing is in place..
> 
> So I suggest you proceed as you have with the fixed symbol version.

Ok, fine - I have implemented and tested both solutions with current libmlx4 + 
Connect-X3 and libsif + SIF using the libibverbs and kernel patch sets in the same box, 
with a small amendment to the size checking in the uverbs ibv_reg_mr path and feel 
I am ready for a v2 then.

Thanks,
Knut

> Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux