On Sun, Sep 04, 2016 at 02:30:33PM +0300, Leon Romanovsky wrote: > +/* User commands. */ > +#define HFI1_CMD_ASSIGN_CTXT 1 /* allocate HFI and context */ > +#define HFI1_IOCTL_ASSIGN_CTXT \ > + _IOWR(IB_IOCTL_MAGIC, __NUM(ASSIGN_CTXT), struct hfi1_user_info) I still vote for dropping the HFI1_CMD_ASSIGN_CTXT defines. Inlining the number is far more readable than that ugly __NUM macro. If it was done consistently you might have an arugment, but just doing it in one place with no purpose is silly. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
