On 8/28/2016 3:58 AM, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
>
> This patch introduces new MLX5_INFINIBAND_VERBOSE Kconfig
> option to enable the output of dump_wqe() which was never
> printed.
>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> ---
> drivers/infiniband/hw/mlx5/Kconfig | 6 ++++++
> drivers/infiniband/hw/mlx5/qp.c | 2 +-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/mlx5/Kconfig b/drivers/infiniband/hw/mlx5/Kconfig
> index bce263b..789fef4 100644
> --- a/drivers/infiniband/hw/mlx5/Kconfig
> +++ b/drivers/infiniband/hw/mlx5/Kconfig
> @@ -6,3 +6,9 @@ config MLX5_INFINIBAND
> Mellanox Connect-IB PCI Express host channel adapters (HCAs).
> This is required to use InfiniBand protocols such as
> IP-over-IB or SRP with these devices.
> +
> +config MLX5_INFINIBAND_VERBOSE
> + bool "Enable ConnectX-4/Connect-IB verbosity"
> + depends on MLX5_INFINIBAND
> + ---help---
> + This is a configuration option to enable verbose output to easy debug.
> diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
> index 174d09b..67b58f7 100644
> --- a/drivers/infiniband/hw/mlx5/qp.c
> +++ b/drivers/infiniband/hw/mlx5/qp.c
> @@ -3984,7 +3984,7 @@ int mlx5_ib_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr,
> get_fence(fence, wr), next_fence,
> mlx5_ib_opcode[wr->opcode]);
> skip_psv:
> - if (0)
> + if (IS_BUILTIN(CONFIG_MLX5_INFINIBAND_VERBOSE))
> dump_wqe(qp, idx, size);
> }
This patch is just a big old bunch of no. There is no way I'm sending
in Kconfig changes in a late -rc. Further, there is no way I'm sending
in a Kconfig option for a single debug print function. Third, there is
no way I'm sending in a Kconfig setting for what should be a runtime
debug switch or something like that.
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG Key ID: 0E572FDD
Attachment:
signature.asc
Description: OpenPGP digital signature
