On Thu, 2016-09-01 at 20:13 -0600, Jason Gunthorpe wrote: > On Fri, Sep 02, 2016 at 02:09:26AM +0200, Knut Omang wrote: > > This commit removes the implementation and use of the modify_qp_mask > > helper function from the generic OFED implementation and into individual > > device drivers. > > > > Like with use of the ib_modify_qp_is_ok function it should be up to > > each device driver how to handle bits set in the attribute masks. > > > > With the modify_qp_mask function applied in the generic code, > > drivers would not see the bits that the user process actually sets. > > > > The restrictions imposed by the filter are also beyond what > > is imposed by the Infiniband standard, and would also limit > > future drivers or hardware from checking for unsupported or > > invalid settings. > > I'm not excited about this direction. It is not OK for different > drivers to use different mask algorithms, they must all behave the > same. The problem I am solving here is that SIF expects (and requires) some of the bits that the user correctly sets, but that Mellanox either ignore or need to be 0. So when that mask is applied to the user input, the value that reaches the SIF driver is not correct from SIFs perspective. If the values goes through as the ULP sets them, then all is fine. > What is it you want to do differently, and why shouldn't the mlx > drivers be updated to match that? I'd like the hardware specific part to decide which of the user bits that are interesting and which are not. Currently that information is lost on the way down to the hardware specific calls. Knut > > Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
