On Thu, Aug 25, 2016 at 01:53:06AM -0700, Yuval Shaia wrote: > - memcpy(dev->ibdev.node_desc, IWCH_NODE_DESC, sizeof(IWCH_NODE_DESC)); > + memcpy(dev->ibdev.node_desc, IWCH_NODE_DESC, IB_DEVICE_NODE_DESC_MAX); That is not OK. Nor are any of the similar ones. Copies random kernel memory at the end of IWCH_NODE_DESC. > - memcpy(device->node_desc, device_modify->node_desc, 64); > + memcpy(device->node_desc, device_modify->node_desc, > + IB_DEVICE_NODE_DESC_MAX); And this and similar would be nicer as: > + memcpy(device->node_desc, device_modify->node_desc, > sizeof(device_modify->node_desc)) Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
