Re: [PATCH] RDMA/ocrdma: display ocrdma tech preview status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/18/2016 8:02 AM, Devesh Sharma wrote:
> This patch adds a code to display ocrdma driver technology
> preview status on ocrdma module load.
> 
> Signed-off-by: Devesh Sharma <devesh.sharma@xxxxxxxxxxxx>

This patch isn't really appropriate for the upstream kernel.  The
upstream kernel has no specific state of "tech preview".  I know we use
that term at Red Hat, others like Oracle and SuSE might too, and it has
specific connotations in terms of the provided support SLA for the given
technology, but those things are not relevant to upstream kernels.  For
upstream, only a few things are appropriate:

1) Your driver is in drivers/staging
2) Your driver is fully supported (from a kernel community point of view)


> ---
>  drivers/infiniband/hw/ocrdma/ocrdma_main.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_main.c b/drivers/infiniband/hw/ocrdma/ocrdma_main.c
> index 07d0c6c..9b8774c 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_main.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_main.c
> @@ -444,6 +444,16 @@ void ocrdma_update_link_state(struct ocrdma_dev *dev, u8 lstate)
>  		ocrdma_dispatch_port_active(dev);
>  }
>  
> +void ocrdma_print_tech_preview_status(void)
> +{
> +	printk(KERN_INFO
> +	       "*************************************************************\n");
> +	printk(KERN_INFO
> +	       "RoCE supported at Tech Preview level in all OCE141XX Adapters\n");
> +	printk(KERN_INFO
> +	       "*************************************************************\n");
> +}
> +
>  static struct ocrdma_driver ocrdma_drv = {
>  	.name			= "ocrdma_driver",
>  	.add			= ocrdma_add,
> @@ -456,6 +466,7 @@ static int __init ocrdma_init_module(void)
>  {
>  	int status;
>  
> +	ocrdma_print_tech_preview_status();
>  	ocrdma_init_debugfs();
>  
>  	status = be_roce_register_driver(&ocrdma_drv);
> 


-- 
Doug Ledford <dledford@xxxxxxxxxx>
    GPG Key ID: 0E572FDD

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux