Re: [PATCH] IB/core: Fix possible memory leak in cma_resolve_iboe_route()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/7/2016 12:49 AM, Haggai Eran wrote:
> On 8/5/2016 4:46 PM, Wei Yongjun wrote:
>> 'work' and 'route->path_rec' are malloced in cma_resolve_iboe_route()
>> and should be freed before leaving from the error handling cases,
>> otherwise it will cause memory leak.
>>
>> Fixes: 200298326b27 ('IB/core: Validate route when we init ah')
>> Signed-off-by: Wei Yongjun <weiyj.lk@xxxxxxxxx>
> 
> Reviewed-by: Haggai Eran <haggaie@xxxxxxxxxxxx>

Thanks, applied.

> By the way, what happens when someone moves the get_netdev() device to
> network namespace other than init_net? I don't think that would work
> correctly.

I suspect you're right.  The entire RDMA stack will need an audit for
init_net misuses before containers are a real item I think.


-- 
Doug Ledford <dledford@xxxxxxxxxx>
    GPG Key ID: 0E572FDD

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux