Re: [PATCH libibverbs 2/3] Add support for TCP segmentation offload (TSO)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/18/2016 10:55 AM, Yishai Hadas wrote:
3) Add IBV_WC_TSO to be used as part of poll_cq to report a TSO completion.

why is that needed? what's the proposed/possible applicative usage of
that bit?
It's consistent with the kernel API that adds similar bit for LSO.
http://lxr.free-electrons.com/source/include/rdma/ib_verbs.h#L842

C&P is not something you want to use as argument, specifically if no one uses this 10y old define nowadays (and maybe never)

net.git]# git grep IB_WC_LSO drivers/infiniband/ include/rdma/
drivers/infiniband/hw/mlx4/cq.c: wc->opcode    = IB_WC_LSO;
include/rdma/ib_verbs.h:        IB_WC_LSO,


Specifically, it can give an application an accurate  knowledge about the completion type as done for other cases as part of ibv_post_send as of IBV_WC_BIND_MW, IBV_WC_LOCAL_INV, etc.

IPoIB uses LSO for 10y and doesn't need that, I don't see why user-space IPoIBs would need that


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux