Re: [PATCH] IB/hfi1: Add missing error code assignment before test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2016-08-10 at 07:34 +0200, Christophe JAILLET wrote:
> It is likely that checking the result of 'setup_ctxt' is expected
> here.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
>  drivers/infiniband/hw/hfi1/file_ops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/hfi1/file_ops.c
> b/drivers/infiniband/hw/hfi1/file_ops.c
> index 1ecbec192358..ed76be39b20b 100644
> --- a/drivers/infiniband/hw/hfi1/file_ops.c
> +++ b/drivers/infiniband/hw/hfi1/file_ops.c
> @@ -222,7 +222,7 @@ static long hfi1_file_ioctl(struct file *fp,
> unsigned int cmd,
>  		ret = assign_ctxt(fp, &uinfo);
>  		if (ret < 0)
>  			return ret;
> -		setup_ctxt(fp);
> +		ret = setup_ctxt(fp);
>  		if (ret)
>  			return ret;
>  		ret = user_init(fp);

Thanks for the patch.

Acked-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux