On Wed, 2016-07-27 at 21:06 -0400, ira.weiny wrote: > Checking the return value of the memory allocation call in > init_pervl_scs() was missed. Recently the kmalloc() was changed to > kzalloc() which identified the problem. > > While fixing this issue 2 other bugs were noticed. First, the array > being allocated is accessed in the nomem path which can be reached > before > it is allocated. Second, kernel_send_context was not released on > error. > Fix both of these by creating a more common memory unwind label > structure. > > Fixes: 35f6befc8441 ("staging/rdma/hfi1: Add qp to send context > mapping for PIO") > Reported-by: Leon Romanovsky <leon@xxxxxxxxxx> > Reviewed-by: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx> > Signed-off-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx> > Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx> > --- > drivers/infiniband/hw/hfi1/pio.c | 19 ++++++++++++++++--- > 1 file changed, 16 insertions(+), 3 deletions(-) > Thanks, applied. -- Doug Ledford <dledford@xxxxxxxxxx> GPG KeyID: 0E572FDD
Attachment:
signature.asc
Description: This is a digitally signed message part