On Sat, 2016-07-23 at 09:42 +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sat, 23 Jul 2016 08:30:52 +0200
>
> The sc_return_credits() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not
> needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/infiniband/hw/hfi1/file_ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/file_ops.c
> b/drivers/infiniband/hw/hfi1/file_ops.c
> index c702a00..32c19fa 100644
> --- a/drivers/infiniband/hw/hfi1/file_ops.c
> +++ b/drivers/infiniband/hw/hfi1/file_ops.c
> @@ -228,7 +228,7 @@ static long hfi1_file_ioctl(struct file *fp,
> unsigned int cmd,
> sizeof(struct hfi1_base_info));
> break;
> case HFI1_IOCTL_CREDIT_UPD:
> - if (uctxt && uctxt->sc)
> + if (uctxt)
> sc_return_credits(uctxt->sc);
> break;
>
Thanks, applied.
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: 0E572FDD
Attachment:
signature.asc
Description: This is a digitally signed message part
