Re: [PATCHv2 iw_cxgb4-4.8] RDMA/iw_cxgb4: Use kfree_skb instead of kfree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2016-06-30 at 11:44 +0530, Hariprasad Shenai wrote:
> The commit 0f8ab0b6e91b4d53 ("RDMA/iw_cxgb4: Low resource fixes for
> Memory
> registration") from Jun 10, 2016, leads to the following static
> checker
> warning:
> 
>         drivers/infiniband/hw/cxgb4/mem.c:612 c4iw_alloc_mw()
>         error: use kfree_skb() here instead of kfree(mhp->dereg_skb)
> 
> Also fixes skb leak in c4iw_dealloc_mw
> 
> Fixes: 0f8ab0b6e91b4d53 ("RDMA/iw_cxgb4: Low resource fixes for
> Memory registration")
> 
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Hariprasad Shenai <hariprasad@xxxxxxxxxxx>
> ---
> 
> V2: kfree_skb() checks if skb is freed, so no need to check again.
>     Based on review comments by Leon Romanovsky <leon@xxxxxxxxxx>
> 
>  drivers/infiniband/hw/cxgb4/mem.c | 26 +++++++++++++++-----------
>  1 file changed, 15 insertions(+), 11 deletions(-)
> 

Thanks, applied.

-- 
Doug Ledford <dledford@xxxxxxxxxx>
              GPG KeyID: 0E572FDD

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux