I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx> Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx> --- net/rds/ib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/rds/ib.c b/net/rds/ib.c index b5342fd..07a783e 100644 --- a/net/rds/ib.c +++ b/net/rds/ib.c @@ -48,11 +48,11 @@ unsigned int rds_ib_mr_1m_pool_size = RDS_MR_1M_POOL_SIZE; unsigned int rds_ib_mr_8k_pool_size = RDS_MR_8K_POOL_SIZE; unsigned int rds_ib_retry_count = RDS_IB_DEFAULT_RETRY_COUNT; -module_param(rds_ib_mr_1m_pool_size, int, 0444); +module_param(rds_ib_mr_1m_pool_size, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(rds_ib_mr_1m_pool_size, " Max number of 1M mr per HCA"); -module_param(rds_ib_mr_8k_pool_size, int, 0444); +module_param(rds_ib_mr_8k_pool_size, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(rds_ib_mr_8k_pool_size, " Max number of 8K mr per HCA"); -module_param(rds_ib_retry_count, int, 0444); +module_param(rds_ib_retry_count, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(rds_ib_retry_count, " Number of hw retries before reporting an error"); /* -- 2.9.2 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
