This looks reasonable to me, but a little question below: > @@ -1442,7 +1491,8 @@ static void nvmet_rdma_remove_port(struct nvmet_port *port) > { > struct rdma_cm_id *cm_id = port->priv; > > - rdma_destroy_id(cm_id); > + if (cm_id) > + rdma_destroy_id(cm_id); > } How is ->remove_port synchronized vs the RDMA/CM even handler? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html