Re: [PATCH 02/28] IB/hfi1: Fix to fully initialize send context area

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 28, 2016 at 12:32:09PM -0400, ira.weiny wrote:
> On Tue, Jul 26, 2016 at 08:26:57AM +0300, Leon Romanovsky wrote:
> > On Mon, Jul 25, 2016 at 01:38:01PM -0700, Dennis Dalessandro wrote:
> > > From: Tymoteusz Kielan <tymoteusz.kielan@xxxxxxxxx>
> > > 
> > >  
> > > -	dd->kernel_send_context = kmalloc_node(dd->num_send_contexts *
> > > +	dd->kernel_send_context = kzalloc_node(dd->num_send_contexts *
> > >  					sizeof(struct send_context *),
> > >  					GFP_KERNEL, dd->node);
> > 
> > Dennis,
> > Don't you want to check kzalloc_node execution success
> > prior to use dd->kernel_send_context?
> 
> Again thanks for catching this.  Follow on fix was sent which depends on this
> patch.

No problem.

> 
> Thanks,
> Ira
> 
> > 
> > >  	dd->kernel_send_context[0] = dd->vld[15].sc;
> > > 
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux