On Tue, 26 Jul 2016 08:46:29 +0300
Leon Romanovsky <leon@xxxxxxxxxx> wrote:
> On Tue, Jul 12, 2016 at 12:36:36PM -0700, Adit Ranadive wrote:
> > This patch adds the various Verbs structures that we support in the
> > virtual RDMA device. We have re-mapped the ones from the RDMA core stack
> > to make sure we can maintain compatibility with our backend.
> >
> > Reviewed-by: Jorgen Hansen <jhansen@xxxxxxxxxx>
> > Reviewed-by: George Zhang <georgezhang@xxxxxxxxxx>
> > Reviewed-by: Aditya Sarwade <asarwade@xxxxxxxxxx>
> > Reviewed-by: Bryan Tan <bryantan@xxxxxxxxxx>
> > Signed-off-by: Adit Ranadive <aditr@xxxxxxxxxx>
> > ---
> > drivers/infiniband/hw/pvrdma/pvrdma_ib_verbs.h | 450
> > +++++++++++++++++++++++++ 1 file changed, 450 insertions(+)
> > create mode 100644 drivers/infiniband/hw/pvrdma/pvrdma_ib_verbs.h
> >
>
> ...
>
> > +enum pvrdma_wc_opcode {
> > + PVRDMA_WC_SEND,
>
> ...
>
> > + PVRDMA_WC_RECV_RDMA_WITH_IMM
> > +};
>
> ....
> > +
> > +enum pvrdma_wc_flags {
> > + PVRDMA_WC_GRH = 1 << 0,
> ....
>
> > + PVRDMA_WC_FLAGS_MAX = PVRDMA_WC_WITH_VLAN,
> > +};
> > +
>
> Sometimes you put "," at the last line of enums, sometimes you don't.
> Can you please be more consistent?
>
> Thanks.
Done. Added , to the enums missing it. Will send this out in v3.
Thanks,
Adit
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
