On Wed, Jul 27, 2016 at 03:38:36PM -0400, Chuck Lever wrote:
> Other similar functions (mlx5_ib_post_recv being the closest)
> return EINVAL in this case.
>
> Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
Thanks Chuck,
You are absolutely right, it should be EINVAL error.
Do you mind if I submit it by myself together with other mlx5 fixes?
Looks ok, except title :)
Acked-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> ---
> Hi Matan, Leon-
>
> I noticed this nit while debugging a problem in xprtrdma.
>
> drivers/infiniband/hw/mlx5/qp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
> index ce0a7ab..b0e5498 100644
> --- a/drivers/infiniband/hw/mlx5/qp.c
> +++ b/drivers/infiniband/hw/mlx5/qp.c
> @@ -3436,7 +3436,7 @@ int mlx5_ib_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr,
> num_sge = wr->num_sge;
> if (unlikely(num_sge > qp->sq.max_gs)) {
> mlx5_ib_warn(dev, "\n");
> - err = -ENOMEM;
> + err = -EINVAL;
> *bad_wr = wr;
> goto out;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Attachment:
signature.asc
Description: Digital signature
