Re: [PATCH 2/2] ipoib: Ratelimit messages which can flood a host.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 26, 2016 at 05:38:49PM +0300, Nikolay Borisov wrote:
> In case an infiniband outtage occurs the messages modified
> in this patchset can flood the host with a rate of 1 message per

s/patchset/patch

> ms which is a lot. Using the ratelimited version of ipoib_warn
> fixes the issue by limiting at most 10 messages in 5 seconds.
> 
> Signed-off-by: Nikolay Borisov <kernel@xxxxxxxx>
> ---
>  drivers/infiniband/ulp/ipoib/ipoib_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> index 7d3281866ffc..dd5b4afbc00b 100644
> --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> @@ -1034,9 +1034,9 @@ static void ipoib_timeout(struct net_device *dev)
>  {
>  	struct ipoib_dev_priv *priv = netdev_priv(dev);
>  
> -	ipoib_warn(priv, "transmit timeout: latency %d msecs\n",
> +	ipoib_warn_rl(priv, "transmit timeout: latency %d msecs\n",
>  		   jiffies_to_msecs(jiffies - dev->trans_start));
> -	ipoib_warn(priv, "queue stopped %d, tx_head %u, tx_tail %u\n",
> +	ipoib_warn_rl(priv, "queue stopped %d, tx_head %u, tx_tail %u\n",

So this is just to hide the hide the problem, the real question is what is
causing this to happen a lot.

>  		   netif_queue_stopped(dev),
>  		   priv->tx_head, priv->tx_tail);
>  	/* XXX reset QP, etc. */
> -- 
> 2.5.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux