On Fri, 8 Jul 2016, Hal Rosenstock wrote: > > Its used to calculate the offset. See the macro definition. > > Isn't it used to calculate the index not the offset (and that part of > index is not used anywhere AFAIT) ? _width, _offset and _counter are all just used for the calculation of "index" which is the final value that is stored in the port table. Ok we can change that to index to be accurate? #define PORT_PMA_ATTR(_name, _counter, _width, _offset) \ struct port_table_attribute port_pma_attr_##_name = { \ .attr = __ATTR(_name, S_IRUGO, show_pma_counter, NULL), \ .index = (_offset) | ((_width) << 16) | ((_counter) << 24), \ .attr_id = IB_PMA_PORT_COUNTERS , \ } -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html