Re: [PATCH for v4.7] IB/srpt: Reduce QP buffer size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 6/24/2016 6:58 AM, Parav Pandit wrote:
Hi Bart,

On Thu, Jun 23, 2016 at 1:05 PM, Bart Van Assche
<bart.vanassche@xxxxxxxxxxx> wrote:
-       qp_init->cap.max_send_sge = max(sdev->device->attrs.max_sge_rd,
-                                       sdev->device->attrs.max_sge);
+       qp_init->cap.max_send_sge = SRPT_DEF_SG_PER_WQE;
        qp_init->port_num = ch->sport->port;

Instead of static value, you might want to do

max_send_sge = min(max_sge_rd, max_sge, SRPT_DEF_SG_PER_WQE)

I like Parav fix,

Reviewed-by: Max Gurtovoy <maxg@xxxxxxxxxxxx>



So that it can still remain functional (if not as high performance)
for hw and software devices with SGE of 8 or 12 also?
Otherwise QP creation itself might fail for values lower than 16.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux