On Wed, Jun 15, 2016 at 02:21:56AM -0400, ira.weiny@xxxxxxxxx wrote:
> From: Ira Weiny <ira.weiny@xxxxxxxxx>
>
> Allow for a common core function to get firmware version strings
> from the individual devices.
>
> In later patches this format can then then be used to pass a
> properly formated version string through the IPoIB layer.
>
> The problem with the current code in the IPoIB layer is that it is
> specific to certain hardware types.
>
> Furthermore, this gives us a common function through which the core
> can provide a common sysfs entry. Eventually we may want to
> remove the sysfs export but this provides for user space backwards
> compatibility.
>
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>
> Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>
>
> ---
> Changes from V0:
> Add parameter names to function signature
> change default string assignment
>
> drivers/infiniband/core/device.c | 9 +++++++++
> include/rdma/ib_verbs.h | 3 +++
> 2 files changed, 12 insertions(+)
>
> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> index 5c155fa91eec..760ef603a468 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -311,6 +311,15 @@ static int read_port_immutable(struct ib_device *device)
> return 0;
> }
>
> +void ib_get_device_fw_str(struct ib_device *dev, char *str, size_t str_len)
> +{
> + if (dev->get_dev_fw_str)
> + dev->get_dev_fw_str(dev, str, str_len);
> + else
> + str[0] = '\0';
Interesting point, what is better for the caller to get as a version?
You chose empty string, but it can be all Fs or all 0s.
> +}
> +EXPORT_SYMBOL(ib_get_device_fw_str);
Attachment:
signature.asc
Description: Digital signature
