From: Ira Weiny <ira.weiny@xxxxxxxxx> Currently there are 3 ways to get the firmware version for an RDMA device. 1) verbs query device 2) ethtool 3) sysfs entry Both 1 and 2 are expecting a 64bit field which is vendor specific and encodes a 3 number version. Some hardware, like OPA, only has 2 numbers in it's version, while other hardware like cxgb4 has 4. Support for the sysfs entry was left to the devices but generally done in a "common" way. This series moves to unify firmware version reporting by creating the ib_get_device_fw_str method within the ib_device. With this we can then do 3 things. 1) Support device dependent formats of version strings with ethtool (IPoIB) 2) Support a common sysfs entry in the core for backwards compatibility which can either be changed to a common FW version string with the new verbs interface or simply removed in favor of using ethtool. 3) Eventually drop the sysfs entry once we can get user space tools off of it. If we decide not to have an interface through verbs (require the use of ethtool via IPoIB) iWarp and RoCE devices don't even have to have this support at all and the code can be eliminated for those devices. 1 and 2 are done with this patch series. 3 needs to be decided by the community if, and when, sysfs support can be dropped. NOTE: I have tested these patches with mlx4, qib, and hfi1. Other drivers were compile tested only. Ira Weiny (13): IB/core: Add get FW version string to the core IB/cxgb3: Support device FW version string IB/cxgb4: Support device FW version string IB/i40iw: Support device FW version string IB/mlx4: Support device FW version string IB/mlx5: Support device FW version string IB/mthca: Supprot device FW version string IB/nes: Support device FW version string IB/ocrdma: Support device FW version string IB/usnic: Support device FW version string IB/ipoib: Use new device FW version string IB/core: Export a common fw_ver sysfs entry IB/hfi1: Add device FW version string drivers/infiniband/core/device.c | 9 ++++++++ drivers/infiniband/core/sysfs.c | 16 +++++++++++++- drivers/infiniband/hw/cxgb3/iwch_provider.c | 27 +++++++++++------------ drivers/infiniband/hw/cxgb4/provider.c | 31 +++++++++++++------------- drivers/infiniband/hw/hfi1/hfi.h | 2 ++ drivers/infiniband/hw/hfi1/verbs.c | 15 +++++++++++++ drivers/infiniband/hw/i40iw/i40iw_verbs.c | 24 +++++++++----------- drivers/infiniband/hw/mlx4/main.c | 24 ++++++++++---------- drivers/infiniband/hw/mlx5/main.c | 21 +++++++++--------- drivers/infiniband/hw/mthca/mthca_provider.c | 24 ++++++++++---------- drivers/infiniband/hw/nes/nes_verbs.c | 33 ++++++++++++---------------- drivers/infiniband/hw/ocrdma/ocrdma_main.c | 19 ++++++++-------- drivers/infiniband/hw/usnic/usnic_ib_main.c | 16 ++++++++++++++ drivers/infiniband/hw/usnic/usnic_ib_sysfs.c | 17 -------------- drivers/infiniband/ulp/ipoib/ipoib_ethtool.c | 6 ++--- include/rdma/ib_verbs.h | 3 +++ 16 files changed, 157 insertions(+), 130 deletions(-) -- 1.8.2 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
