On 6/6/2016 8:15 PM, Greg KH wrote:
On Mon, Jun 06, 2016 at 10:04:13AM -0700, Christoph Hellwig wrote:
On Mon, Jun 06, 2016 at 07:34:40PM +0300, Max Gurtovoy wrote:
Replace u64 casting to ULL.
Signed-off-by: Max Gurtovoy <maxg@xxxxxxxxxxxx>
---
include/rdma/ib_verbs.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
index c97357b..7e440d4 100644
--- a/include/rdma/ib_verbs.h
+++ b/include/rdma/ib_verbs.h
@@ -219,8 +219,8 @@ enum ib_device_cap_flags {
IB_DEVICE_SIGNATURE_HANDOVER = (1 << 30),
IB_DEVICE_ON_DEMAND_PAGING = (1ULL << 31),
IB_DEVICE_SG_GAPS_REG = (1ULL << 32),
- IB_DEVICE_VIRTUAL_FUNCTION = ((u64)1 << 33),
- IB_DEVICE_RAW_SCATTER_FCS = ((u64)1 << 34),
+ IB_DEVICE_VIRTUAL_FUNCTION = (1ULL << 33),
+ IB_DEVICE_RAW_SCATTER_FCS = (1ULL << 34),
Looks good, but can you also convert the whole enum to this
style?
This was my v1 patch but many peaple didn't like it so much.
I coordinated with Doug that I'll push small patch for now and later we
can cast the whole enum to preferable style.
If this "convert the whole thing" is going to happen, can you use the
BIT() for this please? I asked that last time this patch came by...
It's a maintainers desicion :)
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
