Re: [PATCH libmlx5 7/7] Use configuration symbol for always in-line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/06/2016 19:10, Jason Gunthorpe wrote:
On Wed, Jun 01, 2016 at 04:48:02PM +0300, Yishai Hadas wrote:

 #define HIDDEN		__attribute__((visibility("hidden")))

If you are going to do one you might as well do them all...

BTW, it is strange to use visibility("hidden"), usually you'd use
-fvisibility=hidden during the compile and then use
visibility("default") only on the one or two functions that need to be
public.

Much safer.


It wasn't added by this series :)
Actually, it isn't used in libmlx5 so it should be dropped.

+#ifdef HAVE_FUNC_ATTRIBUTE_ALWAYS_INLINE
+#define ALWAYS_INLINE __attribute__((always_inline))
+#else
+#define ALWAYS_INLINE
+#endif


Jason


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux