Re: [PATCH 06/10] IB/hfi1: Add ioctl() interface for user commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/24/2016 04:54 PM, Jason Gunthorpe wrote:
> On Tue, May 24, 2016 at 08:29:41PM +0000, Hefty, Sean wrote:
>>> Let's assume that you are planning to provide block of 20 ioctls per
>>> device. Right now, there are 10 (or 8 if we count driver families) drivers in
>>> drivers/infiniband/hw/ + 1 is coming (HSI) + uverbs (approximately 40)
>>> => 8 * 20 + 20 + 40 = 220 ioctls => we already in shortage without room
>>> to expansion.
>>
>> Ioctl commands are naturally scoped per open file.  Unless the
>> opened file supports ioctls directed to every piece of hardware, I
>> don't see why there's an obsession with command space.
> 
> The kernel standard is to have ioctl numbers be globally unique, even
> though technically you are right and they are scoped to a file.

A not very well followed standard...


-- 
Doug Ledford <dledford@xxxxxxxxxx>
              GPG KeyID: 0E572FDD


Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux